Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trezorctl firmware-update fix #224

Closed
bosomt opened this issue Dec 18, 2018 · 1 comment
Closed

trezorctl firmware-update fix #224

bosomt opened this issue Dec 18, 2018 · 1 comment
Assignees
@matejcik
Labels
trezorlib Python library and the command line trezorctl tool.
Milestone
python-trezor-next

Comments

@bosomt
Copy link

bosomt commented Dec 18, 2018

trezorctl asks you to confirm to load FW but if it's still empty it will load it immediately even it says

Please confirm action on device...

trezorctl firmware-update -f ./Downloads/trezor-1.7.2.bin
Firmware fingerprint: 4d5c7ac191dba315b2433af27c187925fb713d06984cc6f566231d809dd8d370
Please confirm action on device...
True
@prusnak
Copy link
Member

prusnak commented Dec 18, 2018 •
edited
Loading

We should skip "Please confirm action on device" step when Features.firmware_present == False (not None though, in this case this is older bootloader and we cannot guess that).

Related: "Please confirm action on device" should read "Please confirm the action on the device"

@matejcik matejcik transferred this issue from trezor/python-trezor Jun 5, 2019
@matejcik matejcik self-assigned this Jun 5, 2019
@matejcik matejcik added enhancement trezorlib Python library and the command line trezorctl tool. labels Jun 5, 2019
@matejcik matejcik added this to the python-trezor-next milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
trezorlib Python library and the command line trezorctl tool.
Projects
None yet
Milestone
python-trezor-next
Development

No branches or pull requests
3 participants
@prusnak @matejcik @bosomt