New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowance checking in fw #2923

Open

Hannsek opened this issue Mar 30, 2023 · 0 comments

Labels

altcoin

Contributor

Hannsek commented Mar 30, 2023 •

edited

we might actually want to implement allowance checking in firmware even before the general contract decoding. it looks easy, it's a call on the ERC20 ABI with address and amount or UINT_MAX

related issue: #69

Hannsek added the altcoin label

cbergqvist added a commit to cbergqvist/trezor-firmware that referenced this issue


          feat(core): Make allowance check nicer (implements trezor#2923)

ec6f11d

Properly displays recipient address and allowance amount for the `approve` function, similar to ERC20 token transfers.

[no changelog]

cbergqvist added a commit to cbergqvist/trezor-firmware that referenced this issue


          feat(core): Make allowance check nicer (implements trezor#2923)

c181c8c

Properly displays recipient address and allowance amount for the `approve` function, similar to ERC20 token transfers.

[no changelog]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment