Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trezorctl downloads firmwares from Beta Wallet #411

Closed
tsusanka opened this issue Aug 14, 2019 · 2 comments · Fixed by #420
Closed

Trezorctl downloads firmwares from Beta Wallet #411

tsusanka opened this issue Aug 14, 2019 · 2 comments · Fixed by #420
Assignees
@matejcik
Labels
trezorlib Python library and the command line trezorctl tool.

Comments

@tsusanka
Copy link
Contributor

If I run trezorctl firmware-update it downloads the firmware from https://beta-wallet.trezor.io/data/firmware/2/trezor-2.1.0.bin, which also means that it currently downloads 2.1.4, which is meant for beta testing only.

I don't think this is a good idea. Is there any reason to download from Beta instead of production?
@tsusanka tsusanka added P3 Medium trezorlib Python library and the command line trezorctl tool. labels Aug 14, 2019
@tsusanka tsusanka added this to the 2019-09 milestone Aug 14, 2019
@prusnak
Copy link
Member

prusnak commented Aug 14, 2019

I think the rationale was that trezorctl users are more advanced and they should get the newest stuff first.

We can discuss this whether this is a good idea.

@tsusanka tsusanka modified the milestones: 2019-09, backlog Aug 16, 2019
@prusnak prusnak mentioned this issue Aug 16, 2019
Merged
@prusnak
Copy link
Member

prusnak commented Aug 16, 2019

PR in #420

@prusnak prusnak added the W1/2 label Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejcik matejcik

Labels
trezorlib Python library and the command line trezorctl tool.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

python: add --beta switch to trezorctl firmware_update command trezor/trezor-firmware
3 participants
@prusnak @matejcik @tsusanka