Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for PSBT (BIP-174) #49

Open
prusnak opened this issue Nov 13, 2018 · 10 comments
Open

add support for PSBT (BIP-174) #49

prusnak opened this issue Nov 13, 2018 · 10 comments
Assignees
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. epic Issue that aggregates a larger area of tasks. feature Product related issue visible for end user

Comments

@prusnak
Copy link
Member

prusnak commented Nov 13, 2018

No description provided.

@tsusanka
Copy link
Contributor

Since our freezing date is in two weeks, there is no chance we can do this in time. Also, SLIP-39 has higher priority. I'm moving this to backlog.

@prusnak prusnak transferred this issue from trezor/trezor-core Apr 17, 2019
@prusnak prusnak added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label Apr 17, 2019
@prusnak prusnak added this to the backlog milestone Apr 17, 2019
@prusnak prusnak added core Trezor Core firmware. Runs on Trezor Model T and T2B1. and removed core Trezor Core firmware. Runs on Trezor Model T and T2B1. labels Apr 17, 2019
@willcl-ark
Copy link

If implemented, would this support Multisig PSBTs?

@prusnak
Copy link
Member Author

prusnak commented Apr 25, 2019

Yes

@prusnak
Copy link
Member Author

prusnak commented Oct 10, 2019

Let's refactor the signing code first: #617

@urza
Copy link

urza commented Sep 11, 2020

Hello, may I ask what is current status of PSBT support in Trezor?

I would appreciate if someone could provide overview, something like:

  • Which devices support PSBT (T / One)
  • What of BIP174 functionality is supported and if there are any limitations, what isn't possible.
  • How can PSBT be handled from developer's perspective (integration into other software - which tools/library/methods to use and ideally short example)
  • How can PSBT be handled from user's perspective (does web wallet support it? electrum? core with hwi?)

🙏

@prusnak
Copy link
Member Author

prusnak commented Sep 11, 2020

Which devices support PSBT (T / One)

Right now, you can sign PSBT via HWI with both Trezor One and Model T. We will add PSBT signing via SD-card, but there are things with more priority (like native hardware Coinjoin, etc.) on our list first.

@matejcik
Copy link
Contributor

what is current status of PSBT support in Trezor?

There is no direct support of the PSBT encoding in hardware.

(I believe this issue was originally motivated by storing PSBT files on the SD card for model T, which is not done at the moment.)

Client software that can decode the PSBT format can translate it to Trezor calls, so any transaction that Trezor can sign, it can in theory do so via PSBT.

That is, you can generate a PSBT for offline signing, transfer it to an offline host on a flash drive or something, use Electrum or HWI with connected Trezor to sign it, and then transfer it back for broadcast.

There's limited support for multisig, because ... well (vague gestures). There are no good standards around multisig UX. BIP-174 allows encoding (most of?) the necessary raw data, but that doesn't translate to good support.

Multi-party signing is now possible on Trezor T via EXTERNAL script type, with either a pre-signed input (supported in BIP-174) or SLIP-19 ownership proofs (not supported, could be added via a vendor extension). AFAIK neither Electrum nor HWI supports that yet.

Arbitrary scripts are not supported on Trezor, only the standard ones.

  • How can PSBT be handled from developer's perspective

HWI, which can be used in Python as hwilib

  • How can PSBT be handled from user's perspective

HWI or Electrum

@jimmysong
Copy link

So is there an ETA for PSBT support via SD card? I would really like this for my multisig setup.

@tsusanka tsusanka added the feature Product related issue visible for end user label Oct 29, 2020
@tsusanka tsusanka removed the S4 Low label Feb 19, 2021
@fooedge2
Copy link

Any update on BIP174 with sd card?

@prusnak
Copy link
Member Author

prusnak commented Apr 13, 2021

PSBTs via SD card are not on the immediate roadmap. You can sign PSBTs via HWI with no issues.

@tsusanka tsusanka moved this from 📥 Inbox to 📽 Product in Firmware · Backlog 🗂 Oct 5, 2021
@tsusanka tsusanka removed this from the backlog milestone Oct 6, 2021
@alex-jerechinsky alex-jerechinsky added this to 💻 Code in Backlog 🗂 Oct 22, 2021
@alex-jerechinsky alex-jerechinsky removed this from 📽 Product in Firmware · Backlog 🗂 Oct 22, 2021
@alex-jerechinsky alex-jerechinsky moved this from 💻 Code to 📽 Product in Backlog 🗂 Oct 22, 2021
@hynek-jina hynek-jina removed the LOW label May 6, 2022
@Hannsek Hannsek added this to the 🔌 Trezor unplugged milestone Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. epic Issue that aggregates a larger area of tasks. feature Product related issue visible for end user
Projects
Status: No status
Backlog 🗂
📽 Product
Development

No branches or pull requests