Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Wei amount and contract address for unknown tokens #800

Closed
prusnak opened this issue Jan 21, 2020 · 1 comment · Fixed by #1345
Closed

Show Wei amount and contract address for unknown tokens #800

prusnak opened this issue Jan 21, 2020 · 1 comment · Fixed by #1345
Labels
altcoin Any non-Bitcoin coins feature Product related issue visible for end user

Comments

@prusnak
Copy link
Member

prusnak commented Jan 21, 2020

We could improve UX of unknown tokens, by:

  1. showing wei amount of the token being transacted
  2. showing the contract address on the second page of the confirm dialog
@prusnak prusnak added feature altcoin Any non-Bitcoin coins labels Jan 21, 2020
@prusnak prusnak added this to the backlog milestone Jan 21, 2020
@prusnak prusnak mentioned this issue Jan 21, 2020
Closed
@tsusanka tsusanka added the feature Product related issue visible for end user label Oct 29, 2020
matejcik added a commit that referenced this issue Nov 12, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
5f83219
matejcik added a commit that referenced this issue Nov 12, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
278b2a3
@matejcik matejcik mentioned this issue Nov 12, 2020
Merged
matejcik added a commit that referenced this issue Nov 12, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
3756a05
matejcik added a commit that referenced this issue Nov 13, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
43c90ba
matejcik added a commit that referenced this issue Nov 20, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
357b047
matejcik added a commit that referenced this issue Nov 20, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
2541f4a
matejcik added a commit that referenced this issue Nov 20, 2020
@matejcik
feat(core): improve ethereum tokens ui (fixes #800)
2959ae1
tsusanka pushed a commit that referenced this issue Nov 20, 2020
@matejcik @tsusanka
feat(core): improve ethereum tokens ui (fixes #800)
7abe70e
@bosomt
Copy link

bosomt commented Dec 21, 2020

QA OK

Nixos
Suite be4e3a36f7dbe15b2b203f66de11edc50a6665b8
Device: fw-regular-2.3.5-889a3699

@matejcik matejcik mentioned this issue Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
altcoin Any non-Bitcoin coins feature Product related issue visible for end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ethereum improvements trezor/trezor-firmware
4 participants
@prusnak @tsusanka @bosomt @ZdenekSL