Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tezos: add baking support #114

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Tezos: add baking support #114

wants to merge 7 commits into from

Conversation

adonagy
Copy link
Contributor

@adonagy adonagy commented Apr 29, 2019

Ads signing for baking and endorsement operation.

Resubmitting PR from trezor/trezor-core#473 and trezor/trezor-common#267

@adonagy
Copy link
Contributor Author

adonagy commented Apr 29, 2019

Currently working on a better way to display the signed operations. Considering worklfow.startdefault() as suggested in trezor/trezor-core#473

@tsusanka tsusanka requested a review from matejcik April 29, 2019 09:22
@tsusanka tsusanka added the core Trezor Core firmware. Runs on Trezor Model T and T2B1. label Apr 29, 2019
@tsusanka tsusanka added this to the 2019-06 milestone Apr 29, 2019
@adonagy
Copy link
Contributor Author

adonagy commented May 3, 2019

I created a new "baking" homescreen for the baking mode. With this approach we can display information of the last signed operation during the baking mode.

We store the last level and the operation type in storage so in case of a restart, we can display the last signed operation when starting baking mode.

@prusnak prusnak self-requested a review May 6, 2019 13:49
@prusnak prusnak self-assigned this May 6, 2019
@prusnak prusnak added altcoin Any non-Bitcoin coins feature labels May 14, 2019
@prusnak prusnak removed their assignment May 24, 2019
@prusnak prusnak modified the milestones: 2019-06, 2019-07 May 24, 2019
@prusnak prusnak modified the milestones: 2019-07 , 2019-08 Jul 1, 2019
@ZdenekSL ZdenekSL modified the milestones: 2019-08, 2019-09 Aug 1, 2019
refactor staking -> baking, delegator -> baker

remove watermarks and tags, force set in trezor

remove unused baking field

tezos: add staking support

fix control staking

refactor names delegator -> baker, staking -> baking, add baking banner

Changed workding in screens

rework message blocking logic - remove all unused message handlers

mode now stored in runtime memory, code adjusted accordingly

reorganize writers

remove redundant check of watermark bytes

writing directly to the hasher with HashWriter

force set the magic_byte/watermark and tag

use directly helpers.validate_full_path

rework baking check, remove debug prints

fix typo - removed space

remove unused dialog

requested changes made

add option to not show signed baker operation on display

Add tezos staking support

refactor staking -> baking, delegator -> baker

Add start/stop baking to trezorctl

remove baking field - send blank TezosControlStaking message

remove unused trezorctl calls and modify tests

restore test file

core/tezos: add new default workflow for displaying signed opertions

core/tezos: screen - handle first ever baking op with the device

core/tezos: fix the overlapping TEZOS BAKING bar

core/tezos: cleanup

Add block/endorsement level validation - double baking/endorsement prevention
@prusnak prusnak modified the milestones: 2019-09, 2019-10 Aug 28, 2019
@prusnak prusnak modified the milestones: 2019-10, 2019-11, backlog Sep 18, 2019
@ZdenekSL ZdenekSL added the feature Product related issue visible for end user label Nov 7, 2019
@prusnak prusnak removed their request for review February 21, 2020 21:11
@matejcik matejcik mentioned this pull request Apr 22, 2020
7 tasks
@tsusanka
Copy link
Contributor

tsusanka commented Aug 4, 2020

Hi there, thank you for your PR. I just wanted to give you a quick update from our side. We are interested in adding this to our firmware but we just don't have enough capacity to review it right now. We would be more than happy to take a closer look at it later, when our capacity frees up a little, likely during the course of 2021. Thank you for your understanding.

@tsusanka tsusanka removed the feature Product related issue visible for end user label Aug 4, 2020
@jurajselep
Copy link
Contributor

Hi there, thank you for your PR. I just wanted to give you a quick update from our side. We are interested in adding this to our firmware but we just don't have enough capacity to review it right now. We would be more than happy to take a closer look at it later, when our capacity frees up a little, likely during the course of 2021. Thank you for your understanding.

this is great news, we will update code to reflect latest 007 protocol update, thanks

@adonagy adonagy requested a review from tsusanka as a code owner March 27, 2021 08:23
@alex-jerechinsky alex-jerechinsky added this to To be reviewed in Firmware Pull Requests via automation Jul 21, 2021
@matejcik matejcik moved this from To be reviewed to Freezer in Firmware Pull Requests Jul 21, 2021
@tsusanka tsusanka moved this from 📥 Inbox to 🧑‍🤝‍🧑 Community Firmware in Firmware · Backlog 🗂 Oct 5, 2021
@tsusanka tsusanka moved this from 🧑‍🤝‍🧑 Community Firmware to 📽 Product in Firmware · Backlog 🗂 Oct 5, 2021
@tsusanka tsusanka removed this from the backlog milestone Oct 6, 2021
@alex-jerechinsky alex-jerechinsky added this to To be reviewed in Pull Requests via automation Oct 22, 2021
@alex-jerechinsky alex-jerechinsky moved this from To be reviewed to Freezer in Pull Requests Oct 22, 2021
@alex-jerechinsky alex-jerechinsky removed this from 📽 Product in Firmware · Backlog 🗂 Oct 22, 2021
@alex-jerechinsky alex-jerechinsky added this to 📽 Product in Backlog 🗂 Oct 22, 2021
@hynek-jina hynek-jina added the feature Product related issue visible for end user label Apr 20, 2022
@hynek-jina hynek-jina removed the MEDIUM label May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
altcoin Any non-Bitcoin coins core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user
Projects
Status: 🔎 Needs review
Backlog 🗂
📽 Product
Development

Successfully merging this pull request may close these issues.

None yet

7 participants