fix(debug): fix show-text import and parameter exceptions #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Mar 7, 2021
| @@ -1,8 +1,9 @@ | |||
| import trezor.messages.DebugLinkShowTextStyle as S | |||
| import trezor.ui.components.common.text as text | |||
There was a problem hiding this comment.
Seems like this should be components.tt.text (that's what we use in the rest of the codebase) - but let's wait for @matejcik - he knows more than me on this topic
Suggested change
| import trezor.ui.components.common.text as text | |
| import trezor.ui.components.tt.text as text |
but I
|
i'm somewhat tempted to throw this code out completely, I don't think we will need it anymore. let's discuss that on standup |
|
i only came across this because i was trying to test the debug usb interface with trezorctl. after looking deeper, trezorctl was using the wire interface anyways, and so was not testing what i wanted to. |
|
closing in favor of #1531 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was testing the usb debug stuff and noticed that this had a stale import. after that was fixed, an exception was due to the positional parameter to
Success.reproduce with:
trezorctl debug show-text blah