New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taproot: WIP send to taproot addresses (legacy) #1718
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
requested review from
andrewkozlik,
matejcik and
onvej-sl
as code owners
July 17, 2021 16:45
prusnak
changed the title
Taproot: send-to taproot addresses (legacy)
Taproot: WIP send-to taproot addresses (legacy)
Jul 17, 2021
prusnak
force-pushed
the
taproot-legacy-sendto
branch
from
July 19, 2021 08:40
15d1388
to
1501522
Compare
prusnak
changed the title
Taproot: WIP send-to taproot addresses (legacy)
Taproot: WIP send to taproot addresses (legacy)
Jul 19, 2021
enable for Bitcoin Testnet and Bitcoin Regtest
because they encode segwit program > 0 and these should no longer be encoded with Bech32 but rather with Bech32m
prusnak
force-pushed
the
taproot
branch
2 times, most recently
from
July 21, 2021 13:31
1ae07ca
to
fa7a218
Compare
prusnak
force-pushed
the
taproot-legacy-sendto
branch
from
July 21, 2021 13:32
1501522
to
bd23779
Compare
because they encode segwit program > 0 and these should no longer be encoded with Bech32 but rather with Bech32m
prusnak
force-pushed
the
taproot-legacy-sendto
branch
from
July 22, 2021 20:07
bd23779
to
898296d
Compare
Superseded by #1760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now, needs more love and testing