Testsuite improvements #1742
Merged
Testsuite improvements #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure filters are properly cleared when the with-block exits
matejcik
force-pushed
the
matejcik/testsuite-tweaks
branch
from
0deffdb
to
ed9c268
Compare
Makes skipping tests much faster, and running individual tests a tiny bit faster. Also makes sure the whole suite always runs against the same device (modulo emulator being restarted)
… to ping" This reverts commit ae0da5e. It seems that there was no good reason for the change in the first place.
There's two udp calls in `UdpTransport._ping()`: - socket.sendall(b"PINGPING") -> this will be instanteous, AND it will raise if the receiving side is not listening. - socket.recv() -> this will wait for SOCKET_TIMEOUT seconds, but only in case the sendall() succeeded. This means that receiving side exists and we are now waiting until it's awake enough to respond. In conclusion, we avoid hammering emulator with PINGPINGs with a timeout so short we don't see an answer. This should avoid the problem occasionally seen in CI and described in #1668
matejcik
force-pushed
the
matejcik/testsuite-tweaks
branch
from
ed9c268
to
8145368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main part is reusing
clientacross test runs, which makes skipping tests significantly faster because we don't have to wait to figure out the model of the device every time.Locally this speeds up legacy emulator test by 30 seconds, which is nice.
Also makes sure the whole suite always runs against the same device (modulo emulator being restarted).
0deffdb should help with the "invalid chunk size" occasional CI failure, as described in #1668. This is not proven however, we will see in practice.