Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-712 support for Trezor T #1835

Merged
merged 5 commits into from Nov 2, 2021
Merged

EIP-712 support for Trezor T #1835

merged 5 commits into from Nov 2, 2021

Commits on Nov 2, 2021

  1. refactor(core/ethereum): rename address.py to helpers.py

    @grdddj
    grdddj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    19e075d View commit details
    Browse the repository at this point in the history

  2. fear(core/ui): add should_show_more layout function 

    Also adding `hold` argument into confirm_blob function
    @grdddj
    grdddj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    454c5b3 View commit details
    Browse the repository at this point in the history

  3. feat(core): plural function supports "key/keys" string 

    Previously function did not work for words ending with "y" and vowel before that
    @grdddj
    grdddj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    f7bee94 View commit details
    Browse the repository at this point in the history

  4. feat(core/ethereum): EIP-712 

    Based on original contribution by Max Kupriianov <xlab@hey.com>

Implemented EIP-712 typed data signatures in Ethereum app.

Add eth_abi into pyproject deps

device test for EIP 712

fixed hex decoding for address

fixup! fixed hex decoding for address

code quality, more pythonic code, removing unused imports

running black and isort on changed files

trezorctl file input for EIP 712 data signing

fixup! code quality, more pythonic code, removing unused imports

fixup! fixup! code quality, more pythonic code, removing unused imports

necessary changes after rebase to master

unit tests for sign_typed_data.py

new protobuf messages, working for nonarray types

simplified and verified solution for our simple data

support for simple arrays, without their confirmation

reverting protobuf value messages to bytes, appropriate changes

showing arrays in Trezor, code quality improvements

data validation on Trezor, minor improvements

using custom types for storing type data instead of dicts, addressing feedback from review

moving helper functions to its own file, tests for decode_data

additional overall tests

support for arrays of structs

adding support for metamask_v4_compat variable

using HashWriter object to collect the final hash continously

minor improvements in code quality

validate_field_type function

streaming values from client without saving them, missing UI

prototype of streamed UI using confirm_properties

accounting for bytes in data, more data types in integration tests

rebase on master, using f-strings

minor fixes and improvements from code review

StructHasher class for the whole hashing process

mypy and style changes

asking users whether to show structs and arrays

protobuf descriptions to fix make defs_check

unifying comments, mypy fix

unit tests for StructHasher class

UI fixtures, skipping device tests for T1

addressing majority of code review comments about code quality and structure

changing file structure - layouts, helpers, sign_typed_data

decode_data renaming and docstring, renaming unit test file

using tuples instead of lists in elifs

layout improvements

excluding core/src/apps/common/confirm.py file from the PR

True/False returning layout with Show more button

code review layout improvements

forgotten br_type argument to should_show_more
    @grdddj
    grdddj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    60e16a2 View commit details
    Browse the repository at this point in the history

  5. chore(legacy): fix build after adding EthereumSignTypedData [no chang… 

    …elog]
    @grdddj
    grdddj committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    b908672 View commit details
    Browse the repository at this point in the history