-
-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise path warning #2161
Comments
I would use "account" or "account type" in place of "script type", because that seems more legible to the end user. Perhaps something like "wrong address path for selected account" covers Bitcoin and altcoin usecases equally? |
I'm sorry if this is not the right place to ask, but isn't |
It is correct for Taproot, but it wouldn't be correct if the specified script type was legacy or SegWit v0 for example. |
@Hannsek I believe we have some designs ready for this, no? |
We have, I'll post them here. (Waiting for Ben's answer on copy) |
(Please remove the exclamation mark from "account!". Nowhere else we shout at the user, and there is already a "!" in the icon.) |
Isn't this done already? @mmilata |
Yes, in #3177. |
When a non-standard BIP32 path is used for a particular coin and script type Trezor shows a warning. This usually pops up at the user at the beginning of the workflow and doesn't say much to someone who isn't expecting it. Also, T1 doesn't show the actual path. We should revise the wording and content of the dialog. Suggestions:
We should also investigate to make sure the wording makes sense everywhere the dialog is used. For example in some altcoins it might be more like "does not match the selected network".
The text was updated successfully, but these errors were encountered: