Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise path warning #2161

Closed
andrewkozlik opened this issue Mar 8, 2022 · 11 comments
Closed

Revise path warning #2161

andrewkozlik opened this issue Mar 8, 2022 · 11 comments
Labels
bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user low hanging fruit Simple, quick task.

Comments

@andrewkozlik
Copy link
Contributor

When a non-standard BIP32 path is used for a particular coin and script type Trezor shows a warning. This usually pops up at the user at the beginning of the workflow and doesn't say much to someone who isn't expecting it. Also, T1 doesn't show the actual path. We should revise the wording and content of the dialog. Suggestions:

  1. "Path m/86'/0'/0'/0/0 does not match the selected coin and script type. Continue?"
  2. "Unknown path m/86'/0'/0'/0/0 for the selected coin and script type. Continue?"

We should also investigate to make sure the wording makes sense everywhere the dialog is used. For example in some altcoins it might be more like "does not match the selected network".

image

@andrewkozlik andrewkozlik added core Trezor Core firmware. Runs on Trezor Model T and T2B1. bitcoin Bitcoin related low hanging fruit Simple, quick task. labels Mar 8, 2022
@trezor-ci trezor-ci added this to 📥 Inbox in Backlog 🗂 via automation Mar 8, 2022
@matejcik
Copy link
Contributor

matejcik commented Mar 8, 2022

I would use "account" or "account type" in place of "script type", because that seems more legible to the end user.

Perhaps something like "wrong address path for selected account" covers Bitcoin and altcoin usecases equally?

@hynek-jina hynek-jina added the feature Product related issue visible for end user label Mar 8, 2022
@hynek-jina hynek-jina moved this from 📥 Inbox to 📽 Product in Backlog 🗂 Mar 8, 2022
@hynek-jina hynek-jina added the LOW label Mar 14, 2022
@andrewkozlik
Copy link
Contributor Author

Proposal
image

@matejcik matejcik added blocked Blocked by external force. Third party inputs required. and removed blocked Blocked by external force. Third party inputs required. labels Apr 12, 2022
@hynek-jina hynek-jina removed the LOW label May 6, 2022
@pedromtcosta
Copy link

I'm sorry if this is not the right place to ask, but isn't 86' /0' /0' /0 /0 a correct path for taproot?

@andrewkozlik
Copy link
Contributor Author

I'm sorry if this is not the right place to ask, but isn't 86' /0' /0' /0 /0 a correct path for taproot?

It is correct for Taproot, but it wouldn't be correct if the specified script type was legacy or SegWit v0 for example.

@matejcik
Copy link
Contributor

@Hannsek I believe we have some designs ready for this, no?
i would love to get this done if so

@Hannsek
Copy link
Contributor

Hannsek commented Apr 12, 2023

We have, I'll post them here. (Waiting for Ben's answer on copy)

@Hannsek
Copy link
Contributor

Hannsek commented Apr 17, 2023

Here it is: image

@Hannsek
Copy link
Contributor

Hannsek commented Aug 30, 2023

Fixed

image

Updated screen.

@matejcik
Copy link
Contributor

(Please remove the exclamation mark from "account!". Nowhere else we shout at the user, and there is already a "!" in the icon.)

@Hannsek
Copy link
Contributor

Hannsek commented Oct 13, 2023

Isn't this done already? @mmilata

@Hannsek Hannsek removed this from the Firmware 2.6.3 release milestone Oct 13, 2023
@mmilata
Copy link
Member

mmilata commented Oct 16, 2023

Yes, in #3177.

@Hannsek Hannsek closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1. feature Product related issue visible for end user low hanging fruit Simple, quick task.
Projects
Archived in project
Backlog 🗂
📽 Product
Development

No branches or pull requests

6 participants