Firmware decoding improvements #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejcik
force-pushed
the
matejcik/remove-signingtools
branch
4 times, most recently
from
18cc0df
to
8071571
Compare
grdddj
reviewed
Oct 24, 2022
matejcik
force-pushed
the
matejcik/remove-signingtools
branch
from
69145a3
to
0caf7aa
Compare
[no changelog]
[no changelog]
The python pipeline is cheap and the "only:changes:" part is problematic in gitlab
matejcik
force-pushed
the
matejcik/remove-signingtools
branch
from
0caf7aa
to
2b646b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to build better tooling for firmware signing, I needed to improve the firmware decoding (and rebuilding). This is done by splitting
trezorlib.firmwareinto multiple independent modules and writing out clearly defined classes for each kind of firmware object.Remote signing functionality is removed from
headertool, as it will live elsewhere and be done differently.in addition,
trezorctlwill now warn about using CoSi-insecure firmwares older than 1.11.2