Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): implement repeated backup. #3743

Merged
merged 5 commits into from
Jun 5, 2024
Merged

feat(core): implement repeated backup. #3743

merged 5 commits into from
Jun 5, 2024

Conversation

ibz
Copy link
Contributor

@ibz ibz commented Apr 23, 2024 •
edited
Loading

Fixes #3640.

@ibz ibz self-assigned this Apr 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T2B1 Safe 3 3280 test(screens) main(screens) 2724
T3T1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@ibz ibz force-pushed the ibz/20240411-custom-group-backup branch from f9bb3b1 to 39e10c4 Compare April 26, 2024 11:15
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch from 2a9d92b to fc39cff Compare April 30, 2024 09:20
@ibz ibz force-pushed the ibz/20240411-custom-group-backup branch from 6dbb8c8 to 14ef89c Compare April 30, 2024 16:13
Base automatically changed from ibz/20240411-custom-group-backup to main May 1, 2024 07:23
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch 15 times, most recently from 28066f6 to 1e6ed37 Compare May 3, 2024 10:18
@ibz ibz marked this pull request as ready for review May 3, 2024 10:47
matejcik
matejcik reviewed May 7, 2024
View reviewed changes
core/src/apps/management/recovery_device/__init__.py Outdated Show resolved Hide resolved
common/protob/messages-management.proto Outdated Show resolved Hide resolved
core/src/apps/management/recovery_device/__init__.py Outdated Show resolved Hide resolved
common/protob/messages-management.proto Outdated Show resolved Hide resolved
core/translations/order.json Outdated Show resolved Hide resolved
core/src/storage/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
tests/click_tests/recovery.py Outdated Show resolved Hide resolved
@ibz
Copy link
Contributor Author

ibz commented May 13, 2024

@Hannsek @matejcik When we trigger a recovery with "unlock repeated backup"... we ask the user how many words there are in the backup. But there can only be 20 or 33, right? So should the 12, 24 options still be there? :-/

matejcik
matejcik reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review

common/protob/messages-management.proto Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_tr/layout.rs Outdated Show resolved Hide resolved
core/embed/rust/src/ui/model_tt/layout.rs Outdated Show resolved Hide resolved
core/src/apps/management/recovery_device/homescreen.py Outdated Show resolved Hide resolved
core/src/apps/management/recovery_device/homescreen.py Outdated Show resolved Hide resolved
core/src/apps/base.py Outdated Show resolved Hide resolved
core/src/apps/base.py Outdated Show resolved Hide resolved
core/src/apps/common/backup.py Outdated Show resolved Hide resolved
legacy/firmware/fsm_msg_common.h Outdated Show resolved Hide resolved
python/src/trezorlib/cli/device.py Outdated Show resolved Hide resolved
@matejcik
Copy link
Contributor

partial review

actually scratch that, that is all from me

but when this is done, the next step is rebasing on top of #3825 :(

@ibz ibz force-pushed the ibz/20240423-repeated-backup branch from 6558d37 to bc813e0 Compare May 29, 2024 06:31
matejcik
matejcik approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@matejcik matejcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ibz ibz force-pushed the ibz/20240423-repeated-backup branch 2 times, most recently from 77f12a6 to a7bc7c2 Compare June 3, 2024 12:50
ibz and others added 4 commits June 4, 2024 08:16
@ibz
feat(core): implement repeated backup
a1b3b3a
@matejcik @ibz
refactor(core): introduce wire filters
a1c9218
@ibz
chore(core): rename recovery type & kind and tweak feature flags
792c719
@matejcik @ibz
refactor(core/wire): move restarting control to handle_single_message
b1ef5ef 
that way it is possible to avoid restarting if we failed to find a
handler for a message (makes it faster with no ill effects because
"failed to find handler" (a) shouldn't happen and (b) doesn't cause any
significant fragmentation)
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch 6 times, most recently from 74698af to 1dd9d4a Compare June 4, 2024 11:18
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch from 1dd9d4a to 307ef45 Compare June 4, 2024 11:49
@peter-sanderson peter-sanderson mentioned this pull request Jun 4, 2024
Merged
@ibz ibz added the translations Put this label on a PR to run tests in all languages label Jun 4, 2024
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch 2 times, most recently from 44c7ee2 to 4c7963a Compare June 5, 2024 08:01
@ibz ibz force-pushed the ibz/20240423-repeated-backup branch from 4c7963a to 3725617 Compare June 5, 2024 08:53
@ibz ibz merged commit ed58409 into main Jun 5, 2024
105 of 109 checks passed
@ibz ibz deleted the ibz/20240423-repeated-backup branch June 5, 2024 09:35
@STew790
Copy link

STew790 commented Jun 13, 2024

QA OK
Tested with #3899 and https://www.notion.so/satoshilabs/Creating-new-multishare-backup-testing-activity-ab3a703401f344dab67537ecb327acf0

Info:

  • OS: Linux x86_64
  • Screen: 1920x1080
  • Device: Trezor T3T1 2.7.2 regular (revision da75d8f)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

@grdddj grdddj grdddj left review comments

@andrewkozlik andrewkozlik andrewkozlik left review comments

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

Assignees

@ibz ibz

Labels
translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement repeated backup
6 participants
@ibz @Hannsek @andrewkozlik @matejcik @STew790 @grdddj