Soft-locking for Trezor T #958
Merged
Commits on Jun 4, 2020
-
-
-
-
-
-
core: use wire.PinCancelled/PinInvalid instead of custom versions
also refactor show_pin_invalid and its usages so that it raises directly note that we are now using PinCancelled instead of ActionCancelled where appropriate
-
-
-
-
-
core: consider lockscreen to be a separate homescreen
this involves some changes to the workflow defaults: * workflow.start_default() takes no arguments * workflow.set_default() (originally replace_default) configures the default that will be started by next call to start_default(). The intended usecase is to set_default() first and then start it separately. * apps.base.set_homescreen() factors out the logic originally in main.py, that decides which homescreen should be launched. This uses set_default() call. start_default() is then used explicitly in main.py
-
-
-
-
-
-
-
-
-
-
-
core: refactor usage of input_signals
this prevents a certain class of UI test failure. It also localizes the use of debuglink signals into the layout classes instead of call sites, which is a design we were already using for confirm_signals
-
-
-
-
-
core/webauthn: Allow confirm_dialog() to return a new state as an alt…
…ernative to the user response.
-
-
-
-
-
-
-
-
-
-
-
tests: rename test_address to get_test_address
so that pytest doesn't think it is a testcase
-
-
-
The original wait_layout was unreliable, because there are no guarantees re order of arrival of the respective events. Still, TT's event handling is basically deterministic, so as long as the host sent its messages close enough to each other, the order worked out. This is no longer the case with the introduction of loop.spawn: TT's behavior is still deterministic, but now ButtonAck is processed *before* the corresponding wait_layout, so the waiting side waits forever. In the new process, the host must first register to receive layout events, and then receives all of them (so the number of calls to wait_layout must match the number of layout changes). DebugLinkWatchLayout message must be version-gated, because of an unfortunate collection of bugs in previous versions wrt unknown message handling; and this interests us because upgrade-tests are using wait_layout feature.
-
-
-
core: call close_others() in place of ButtonRequest
this makes sense, really: close_others() requests UI exclusivity, and that is something that generally happens at the same places we emit a ButtonRequest
-
-
-
core: debuglink interface avoids workflow management
This will have unintended consequences if you call a wirelink function on the debulink interface. TT allows this ... and will behave badly.
-
-
core: start USB after booting apps
This prevents a race condition where sometimes an Initialize message could arrive before the homescreen was fully booted -- and Recovery homescreen would cancel it as part of its bootup sequence.
-
-
-
core: lower scheduler resolution to milliseconds
This avoids problems with large timeouts causing the scheduler queue to think the time counter has overflown, and ordering the autolock task before immediate tasks. The maximum reasonable time difference is 0x20000000, which in microseconds is ~8 minutes, but in milliseconds a more reasonable ~6 days.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.