legacy: initialized field in Features is true only if mnemonic is stored #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsusanka
added
the
blocked
prusnak
requested changes
Apr 30, 2020
tsusanka
removed
the
blocked
|
The deferred label of course needs to stay, because now legacy test suite is not passing. Waits for #958. |
tsusanka
added
the
blocked
andrewkozlik
approved these changes
Apr 30, 2020
prusnak
approved these changes
May 18, 2020
tsusanka
force-pushed
the
tsusanka/965-initialized
branch
from
67a0934
to
ba1f138
Compare
tsusanka
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older firmware supported direct mnemonic load or xprv import. This support was removed from the latest firmware. If someone used this feature and upgraded to the latest fw node deriving does not work anymore and we also incorrectly state that the device as initialized (
features.initialized).This PR modifies this field to
isInitialized() && hasMnemonic()as @prusnak suggested to declare the device as initialized only if it has a mnemonic stored. Because of that I have addedstorage_has(maybestorage_key_existsis better?) to only check if mnemonic is present instead of fetching it.I also had to modify the wipedevice test, which now fails on TT, but that will be fixed by the changes in #958. So I suggest to merge this after the soft lock.
Closes #965