This repository has been archived by the owner on Apr 16, 2019. It is now read-only.
Only compute pubkey on demand. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all hdnode callers to call hdnode_fill_public_key if they need the public key.
|
Merged in. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second half of pull request trezor/trezor-crypto#61. This changes the firmware to compute the public key where necessary and compute the fingerprint of the parent public key as required to produces BIP32 compatible xpub keys.
I'm not so happy with the way ed25519 public keys are handled. I think they should be returned as 32 byte keys, but I didn't want to change the API without discussion and it would also break unit tests in python-trezor. For backward compatibility I now replace the new 01 prefix in these public keys back to 00 again.