Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to factory reset or wipe a locked device #2542

Closed
sorooris opened this issue Oct 7, 2020 · 9 comments
Closed

Unable to factory reset or wipe a locked device #2542

sorooris opened this issue Oct 7, 2020 · 9 comments
Assignees

Comments

@sorooris
Copy link
Contributor

sorooris commented Oct 7, 2020

OS: NixOS
Browser: Chromium 85.0.4183.102
Suite: web staging, commit 426ce98
Firmware Version: any (tested 2.3.4 50854b921, regular and btc-only)

Describe the bug
There is no way to wipe or factory reset device with Suite when device is locked (for example when user forgets their PIN code) compared to the possibility of factory-resetting device in MyTrezor Wallet.

Steps to reproduce:

  1. Connect a device in bootloader mode,
  2. Run Suite app or web version,
  3. See result.

Expected result:
An option to factory reset or wipe device is displayed.

Actual result:
No option to factory reset or wipe device is displayed, only to start the firmware update flow.

Screenshots:
Suite with device in bootloader mode connected:
image
MyTrezor Wallet with device in bootloader mode connected:
image

@sorooris sorooris added the bug Something isn't working as expected label Oct 7, 2020
@sorooris sorooris added this to the 3Q2020 milestone Oct 7, 2020
@matejzak matejzak removed this from the 3Q2020 milestone Oct 23, 2020
@sorooris
Copy link
Contributor Author

@matejzak @alex-jerechinsky could we implement a fix for this in the following releases?

@matejzak
Copy link

Thanks for brining this to our attention. As a matter of fact, it's a good timing to include it in the new Onboarding #3332 development — to be released in May. (1) App Settings should be accessible even without connected device, and (2) we can detect Bootloader mode on the app startup screen here.

cc @slowbackspace

Feature request, design needed. Assigning myself.

@matejzak matejzak assigned matejzak and unassigned matejzak Mar 25, 2021
@matejzak matejzak added this to 🎯 To do in Suite · May 12 🌸 via automation Mar 25, 2021
@slowbackspace
Copy link
Contributor

slowbackspace commented Mar 25, 2021

App Settings should be accessible even without connected device, and (2) we can detect Bootloader mode on the app startup screen [here]

Hold your horses, while the feature seb asks is easy to implement ad-hoc I am afraid that proposed solution is a bit more complicated than it seems.
Adding a button to new "welcome/connect your device", in case the device is connected in bootloader, will be easy, but keep in mind that means suite will need some heavy adjustments (basically we need only allow few actions in settings, forbid accessing dashboard, accounts and other stuff).

From technical POV this new screen for connecting a device is not really part of onboarding process, rather it is separate feature. Right now connecting the device in various states (seedless, bootloader, unreadable device, fw update required a some more) is handled by several separate modals shown in suite (see first screen posted by seb). Sometimes for very good reason. When user has multiple devices connected, and just the one currently selected is seedless, or there is fw update required, or some other state we cannot work with, we show a modal and he might simply chose to work with another device by clicking on "swittch device" button . Handling all this on "welcome screen" really needs tons of work and brainstorming and I really won't expect it can be done at the same time as whole onboarding rewrite. For now I would keep it simple and on welcome screen handle just connection status (connected or not) and let suite take care of various states device might be in.

For example, when you connect a device in bootloader mode you have an option to go update your firmware (which is separate modal/flow, independend of fw update in onboarding), It doesn't make sense force this user to go through onboarding process since the device might be actually initialized, we just don't know about it while it is in bootloader. Actually, In order to start the onboarding process we force user to connect device in normal mode first.

If we really want feature Seb ask for ASAP I would just focus on allowing suite to access settings with bootloader device by adding button to existing modal and making necessary adjustments to prevent triggering actions which doesn't make sense doing with device in bootloader.

@matejzak matejzak removed the bug Something isn't working as expected label Mar 25, 2021
@alex-jerechinsky alex-jerechinsky removed this from 🎯 To do in Suite · May 12 🌸 Apr 28, 2021
@alex-jerechinsky alex-jerechinsky added this to 🎯 To do in Suite · August 11 🍎 via automation May 10, 2021
@matejzak matejzak removed this from 🎯 To do in Suite · August 11 🍎 Jul 8, 2021
@tsusanka
Copy link
Contributor

tsusanka commented Sep 1, 2021

@alex-jerechinsky @matejzak this is a prerequisite to the old wallet deprecation, same as #2854.

@matejzak matejzak added the MEDIUM label Sep 3, 2021
@alex-jerechinsky alex-jerechinsky moved this from Inbox 📥 to Product in Suite · Backlog 🗂 Oct 4, 2021
@tsusanka tsusanka added HIGH and removed MEDIUM labels Oct 6, 2021
@matejzak matejzak added this to 🎯 To do in Suite · November 10 🥫 via automation Oct 6, 2021
@matejzak matejzak assigned matejkriz and unassigned matejzak Oct 7, 2021
@matejzak matejzak moved this from 🎯 To do to 🔥 Priority in Suite · November 10 🥫 Oct 7, 2021
@matejzak
Copy link

matejzak commented Oct 7, 2021

Closely related to #3729

@alex-jerechinsky alex-jerechinsky removed this from 📽 Product in Suite · Backlog 🗂 Oct 8, 2021
@alex-jerechinsky alex-jerechinsky removed this from 🔥 Priority in Suite · November 10 🥫 Oct 21, 2021
@alex-jerechinsky alex-jerechinsky added this to 🎯 To do in November 10 🥫 via automation Oct 21, 2021
@alex-jerechinsky alex-jerechinsky moved this from 🎯 To do to 🔥 Priority in November 10 🥫 Oct 21, 2021
@j2d3
Copy link

j2d3 commented Oct 24, 2021

I have a trezor one, which I have never transferred any funds to, thankfully, and I doubt I ever will. Feels safer on an exchange to be honest. I cannot reset the PIN. The instructions to wipe it say to dismiss the pin matrix when you connect it, but that is not possible, there is not an X to do that. I tried in the websuite using inspect to delete the pin matrix, but there is no "advanced" tab that is clickable anywhere, and I cannot get to any place that will allow me to wipe the device and start over. (When I first got the thing, I did reset it multiple times, but now, the interface has changed.) I do have my recovery phrase and did verify that it has no funds in it via metamask. Anyway - much as I like the idea in theory of "being my own bank" and caring for my own keys, trezor does not make that task simple or comprehensible at all.

@alex-jerechinsky alex-jerechinsky removed this from 🔥 Priority in November 10 🥫 Oct 27, 2021
@alex-jerechinsky alex-jerechinsky added this to 🎯 To do in December 8 🎄 via automation Oct 27, 2021
@matejzak matejzak moved this from 🎯 To do to 🔥 Priority in December 8 🎄 Nov 5, 2021
@alex-jerechinsky alex-jerechinsky moved this from 🔥 Priority to 🏃‍♀️ In progress in December 8 🎄 Nov 19, 2021
@alex-jerechinsky alex-jerechinsky removed this from 🏃‍♀️ In progress in December 8 🎄 Nov 25, 2021
@alex-jerechinsky alex-jerechinsky added this to 🎯 To do in January 19 ☕️ via automation Nov 25, 2021
@matejkriz
Copy link
Member

matejkriz commented Dec 2, 2021

Design:
image

EDIT: updated design
image

Following states in Figma

@hynek-jina hynek-jina moved this from 🎯 To do to 🔥 Priority in January 19 ☕️ Dec 2, 2021
@matejkriz
Copy link
Member

  • consider if there is another special state where it makes sense to provide wipe button directly

@matejkriz matejkriz moved this from 🔥 Priority to 🏃‍♀️ In progress in January 19 ☕️ Dec 15, 2021
@matejkriz matejkriz self-assigned this Dec 15, 2021
January 19 ☕️ automation moved this from 🏃‍♀️ In progress to 🤝 Needs QA Jan 12, 2022
@bosomt
Copy link
Contributor

bosomt commented Jan 12, 2022

QA OK

edit: disregard, it works as expected,
wipe unlocked device: seed is wiped
wipe bootloder device: firmware is wiped

I'm still missing option to Factory reset device as was possible in old wallet.
Even it says factory reset only seed is really wiped and firmware is still present.
@tomasklim @matejkriz @matejzak is this feature planed ?

Info:

  • Suite version: desktop 22.1.1 (7e2101c)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.1.1 Chrome/94.0.4606.81 Electron/15.3.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1680x1050
  • Device: model T 2.4.3 regular.

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in January 19 ☕️ Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
January 19 ☕️
✅ Approved
Development

No branches or pull requests

9 participants