Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the risk of getting stuck when loading a hidden wallet #5016

Open
wendys-cats opened this issue Feb 28, 2022 · 2 comments
Open

Eliminate the risk of getting stuck when loading a hidden wallet #5016

wendys-cats opened this issue Feb 28, 2022 · 2 comments
Labels
feature Product related issue visible for end user

Comments

@wendys-cats
Copy link
Contributor

wendys-cats commented Feb 28, 2022

Describe the issue
It is not always noticeable when server is closed/refuses connection, which can lead to unfortunate situations if the user does not realise the server is down/not responsing, like forever loading wallet either when trying to add hidden wallet or upon re-opening suite. It would be desirable to check responses from electrum server more/to showcase the connection status change in a more visible manner.

Snímek obrazovky 2022-02-28 v 14 59 09

Info:

  • Remembered Wallet: N/A
  • Suite Version: develop app
  • Browser: N/A
  • OS: Windows 10
  • Bridge: bundled 2.0.31
  • Firmware Version: TT 2.4.3

How to reproduce

  1. Connect to electrum server (BTC full node), preferably one that is in high-usage (like electrum.blockstream.info:50002:s, list of available servers here)
  2. Wait for server to refuse connection
  3. Try to create new (hidden) wallet
  4. Forever loading happens, discovery is not in proccess

Expected behavior
Suite will showcase more visibly the server connection status, so user will not try to run discovery when there is no connection to BE.

Additional context
This is not a basic functionality and IMHO users utilising it should understand the functionality and possible drawbacks that come with it.

@wendys-cats wendys-cats added the bug Something isn't working as expected label Feb 28, 2022
@trezor-ci trezor-ci added this to 📥 Inbox in Backlog 🗂 via automation Feb 28, 2022
@hynek-jina hynek-jina added the feature Product related issue visible for end user label Feb 28, 2022
@hynek-jina hynek-jina moved this from 📥 Inbox to 📽 Product in Backlog 🗂 Feb 28, 2022
@hynek-jina hynek-jina added the HIGH label Mar 1, 2022
@hynek-jina hynek-jina changed the title Closed/refused connection to electrum server (BTC full node) is barely noticeable Eliminate the risk of getting stuck when loading a hidden wallet Mar 21, 2022
@hynek-jina
Copy link
Contributor

Todo

Unify the path for hidden wallet with regular wallet:

  • After entering the passphrase go straight to the Suite Dashboard (remove checking balance loading popup)
  • Show (already existing) modal for empty wallet confirmation separately (if needed → logic remains the same as in current version)
    Snímek obrazovky 2022-03-08 v 14 49 10

@hynek-jina hynek-jina added MEDIUM and removed bug Something isn't working as expected HIGH labels Mar 24, 2022
@Kixunil
Copy link

Kixunil commented Mar 28, 2022

Looks like this would greatly benefit from my proposal being implemented. Since that one is stuck, I'm tempted to persuade people to just o with it (perhaps as an experimental feature) out-of-standard. It's designed to not break anything anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product related issue visible for end user
Projects
Status: No status
Backlog 🗂
📽 Product
Development

No branches or pull requests

3 participants