Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable CoinJoin for Trezor One #6609

Closed
hynek-jina opened this issue Oct 20, 2022 · 1 comment · Fixed by #6693
Closed

Disable CoinJoin for Trezor One #6609

hynek-jina opened this issue Oct 20, 2022 · 1 comment · Fixed by #6693
Assignees
@matejkriz
Labels
account Account page & Discovery (loading balances for all activated coins) code Code improvements coinjoin Related to coinjoin feature
Milestone
🥣 Coinjoin - MVP

Comments

@hynek-jina
Copy link
Contributor

hynek-jina commented Oct 20, 2022 •
edited by matejkriz

CoinJoin account and all related functionality will be available for Trezor T only, not for Trezor One.
Prevent all potential conflicts.

Disable add CoinJoin account button with message:
"CoinJoin is supported only on Trezor Model T"

note: We can enable access to CoinJoin account later without CoinJoin functionality, but not for the MVP
@hynek-jina hynek-jina added account Account page & Discovery (loading balances for all activated coins) code Code improvements labels Oct 20, 2022
@hynek-jina hynek-jina added this to the CoinJoin 🥣 milestone Oct 20, 2022
This was referenced Oct 25, 2022
Closed
Closed
@matejkriz matejkriz self-assigned this Oct 26, 2022
@matejkriz matejkriz mentioned this issue Oct 27, 2022
Merged
@bosomt
Copy link
Contributor

bosomt commented Nov 2, 2022

QA OK

Info:

  • Suite version: desktop 22.11.0 (91cc9ae)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/22.11.0 Chrome/100.0.4896.160 Electron/18.3.5 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: model T 2.5.3 Universal (revision eff8e08a9c43a85de8a6ce5afc09b921e3733e26)
  • Transport: bridge 2.0.32

@hynek-jina hynek-jina added the coinjoin Related to coinjoin feature label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejkriz matejkriz

Labels
account Account page & Discovery (loading balances for all activated coins) code Code improvements coinjoin Related to coinjoin feature
Projects
Issues Suite
Archived in project
Milestone
🥣 Coinjoin - MVP
Development

Successfully merging a pull request may close this issue.

feat(coinjoin): disable coinjoin for T1, older firmwares and web trezor/trezor-suite
3 participants
@matejkriz @hynek-jina @bosomt