Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning during Suite launch from command line #9224

Open
filipponeri opened this issue Aug 23, 2023 · 5 comments
Open

Deprecation warning during Suite launch from command line #9224

filipponeri opened this issue Aug 23, 2023 · 5 comments
Labels
code Code improvements connect Connect API related (ie. fee calculation)

Comments

@filipponeri
Copy link

Describe the bug
when launching Trezor Suite on Ubuntu 22.04 from the command line I receive the following Deprecation Warning. How do I deal with it? Thanks!

./Trezor-Suite-23.8.1-linux-x86_64.AppImage
(node:1016272) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use trezor-suite --trace-deprecation ... to show where the warning was created)

Info:

  • Remembered Wallet: yes
  • Suite Version: APP 23.8.1-linux-x86_64
  • Browser: command line
  • OS: Ubuntu 22.04
  • Bridge: trezor-bridge_2.0.27
  • Firmware Version: 2.6.0

How to reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@filipponeri filipponeri added the bug Something isn't working as expected label Aug 23, 2023
@hynek-jina hynek-jina changed the title ./Trezor-Suite-23.8.1-linux-x86_64.AppImage (node:1016272) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. (Use trezor-suite --trace-deprecation ... to show where the warning was created) Deprecation warning during Suite launch from command line Aug 23, 2023
@matejkriz matejkriz added code Code improvements and removed bug Something isn't working as expected labels Sep 11, 2023
@RabbitHole26
Copy link

Hello @matejkriz,

I am experiencing this issue as well. Does this affect the security of the suite software in any significant capacities? I suppose it doesn't since the .AppImage file is still hosted on your website but I rather check before hooking up the device.

Thank you.

@doolio
Copy link

doolio commented Nov 8, 2023

Also see this on Debian 11.

@matejkriz
Copy link
Member

Thank you for your reports! This warning is nothing new and we do not use that deprecated API directly in our codebase, but one of our old dependency use it. We do not know about any abuse of this old API.

Here is some explanation of the context of the warning: https://nodesource.com/blog/understanding-the-buffer-deprecation-in-node-js-10/

@mroz22 The warning during app start comes from usage of bytebuffer dependency, can we replace it with something better maintained? https://github.com/trezor/trezor-suite/blob/develop/packages/protobuf/src/encode.ts/#L74

@matejkriz matejkriz added the connect Connect API related (ie. fee calculation) label Nov 8, 2023
@matejkriz
Copy link
Member

BTW it's not linux related, it can be seen on any platform running Suite from command line

@mroz22
Copy link
Contributor

mroz22 commented Nov 8, 2023

in general, bytebuffer should be replacable. We should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements connect Connect API related (ie. fee calculation)
Projects
Status: 🎯 To do
Development

No branches or pull requests

5 participants