Fix/download emulators #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for the improvements, fine from me. I tried to build the testing image without issues - https://github.com/trezor/trezor-user-env/actions/runs/9449635577 As for the |
grdddj
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x86_64arch because of--recursiveoption (it reads from both emulators/index.html and emulators/arm/index.html)screenshot from current
ghcr.io/trezor/trezor-user-envmove
patch_emulator.shscript to firmware directory and call it from thedownload.shscript. i always forget to do that (on nixos) and it's not mentioned by the docsremove some unnecessary files from the docker image (perhaps there is even more?)