Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to stop counting time when not reviewing cards #24

Closed
ayynonwhymouse opened this issue Nov 1, 2020 · 6 comments
Closed

Option to stop counting time when not reviewing cards #24

ayynonwhymouse opened this issue Nov 1, 2020 · 6 comments
Labels
committed enhancement New feature or request wontfix This will not be worked on

Comments

@ayynonwhymouse
Copy link

Option to stop counting time when not reviewing cards

Let's say I review 50 out of 100 cards in 10 minutes. The addon correctly calculates 5cards/min and says I have an estimated 5 minutes remaining to finish the last 50 cards. But if I go back to the browser screen to take a break, when I begin to study again, the addon accounts for the time I was gone. This artificially lowers the cards/min and makes the ETA not accurate. This could easily be avoided if the app only counted time while you're actually reviewing cards. I believe this is how the "More Decks Stats and Time Left" add-on works. But I want to love your app so much more because it updates dynamically and I can see it while I'm reviewing.

@phu54321
Copy link
Contributor

phu54321 commented Nov 1, 2020

Related issue: #19. This is an intended design, but I think we can improve on it.

This artificially lowers the cards/min and makes the ETA not accurate.

I think addon should visualize the time you've left during reviews. I agree that such long pauses shouldn't affect ETA or CPM stats, though. This means...

  • addon should log the time you were not reviewing cards.
  • but addon shouldn't count for stats calculation.

Currently addon truncates review time to 5 minutes when you've left such a long time, so that wouldn't affect CPM or ETA too much I think.


Some questions.

  • If you're taking a 10-minute break every 50-minute review cycle, shouldn't that be accounted for ETA calculation? (Not for CPM I think, but it should for ETA?)
  • If you've reviewed 100 cards for 60 minutes this morning, toquit it and re-open Anki 4PM, having 200 cards left. Stats goes like this
    • Before: 100/60 = 1.66. ETA = 200 / 1.66 = 2hr
    • After: 100/65 = 1.53. ETA = 2hr 10m

I didn't think 10m bias or 0.16 difference would matter much, but I agree this difference would be distracting.


So addon should detect whether you've left the review completely or you're just taking a short break?

@phu54321 phu54321 added the enhancement New feature or request label Nov 1, 2020
@phu54321 phu54321 pinned this issue Nov 1, 2020
phu54321 added a commit that referenced this issue Nov 16, 2020
- Hotfix: 'again' recorded as 'good' ([Issue #24](#26))
- Fix: possible bar blinkering on AnkiDroid
@phu54321
Copy link
Contributor

  • Has this been resolved?
  • I've removed 'elapsed time' from my message and it seems to work well. Would you try this option?

@phu54321
Copy link
Contributor

phu54321 commented Jan 4, 2021

Closing due to inactivity

@phu54321 phu54321 closed this as completed Jan 4, 2021
@stale
Copy link

stale bot commented Feb 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 9, 2021
@phu54321 phu54321 reopened this Apr 21, 2021
@stale stale bot removed the wontfix This will not be worked on label Apr 21, 2021
@stale
Copy link

stale bot commented Jun 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 20, 2021
@stale stale bot closed this as completed Jun 27, 2021
@Ansh132001
Copy link

Hi, im looking for the same option. I do not want the addon to count for even 5 mins. Is there any way I can change it to 0 in the config?

I understand its intended design but I often take short breaks when I review so id like to have the option to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants