Skip to content

Commit

Permalink
Ignore scrutinizer bugs.
Browse files Browse the repository at this point in the history
  • Loading branch information
Christopher Lorke committed Dec 3, 2018
1 parent ee97053 commit e727140
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/Console/Commands/ImportFileMigrations.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ private function importMigrationSteps(string $migration, array $migrationSteps)
foreach ($this->getValidMigrationSteps($migrationSteps) as $validMigrationStep) {
$this->elasticsearchMigrationService->addMigrationStep(
$migration,
array_get($validMigrationStep, 'type'),
array_get($validMigrationStep, 'params'),
/** @scrutinizer ignore-type */ array_get($validMigrationStep, 'type'),
/** @scrutinizer ignore-type */ array_get($validMigrationStep, 'params'),
array_get($validMigrationStep, 'priority', 1),
array_get($validMigrationStep, 'stopOnFailure', true)
);
Expand All @@ -121,19 +121,19 @@ private function getValidMigrationSteps(array $migrationSteps) : array

foreach ($migrationSteps as $migrationStep) {
$step = require $migrationStep;

$validator = Validator::make($step, [
if (Validator::make($step, [
'type' => 'required|string',
'params' => 'required|array',
'priority' => 'integer',
'stopOnFailure' => 'boolean'
]);

if ($validator->fails()) {
])->fails()) {
throw new \Exception("The migration step is invalid.");
}

if (!$migrationTypes->isMigrationTypeValid(array_get($step, 'type'))) {
if (!$migrationTypes->isMigrationTypeValid(
/** @scrutinizer ignore-type */ array_get($step, 'type')
)) {
throw new \Exception("The migration step type is invalid.");
}

Expand Down

0 comments on commit e727140

Please sign in to comment.