Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save audit logs when a migration event is thrown. #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

triadev
Copy link
Owner

@triadev triadev commented Oct 21, 2018

No description provided.

@triadev triadev self-assigned this Oct 21, 2018
@codecov-io
Copy link

codecov-io commented Oct 21, 2018

Codecov Report

Merging #16 into master will decrease coverage by 0.08%.
The diff coverage is 91.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     92.25%   92.16%   -0.09%     
- Complexity      169      175       +6     
============================================
  Files            27       31       +4     
  Lines           452      498      +46     
============================================
+ Hits            417      459      +42     
- Misses           35       39       +4
Impacted Files Coverage Δ Complexity Δ
.../Repository/ElasticsearchMigrationStepAuditLog.php 100% <100%> (ø) 1 <1> (?)
...ness/Repository/ElasticsearchMigrationAuditLog.php 100% <100%> (ø) 1 <1> (?)
...Provider/ElasticsearchMigrationServiceProvider.php 100% <100%> (ø) 2 <0> (ø) ⬇️
...v_elasticsearch_migration_step_audit_log_table.php 84.61% <84.61%> (ø) 2 <2> (?)
...riadev_elasticsearch_migration_audit_log_table.php 84.61% <84.61%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c982b...ae0eeca. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 21, 2018

Pull Request Test Coverage Report for Build 231

  • 42 of 46 (91.3%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.444%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Database/Migrations/2018_10_21_000000_create_triadev_elasticsearch_migration_audit_log_table.php 11 13 84.62%
src/Database/Migrations/2018_10_21_000000_create_triadev_elasticsearch_migration_step_audit_log_table.php 11 13 84.62%
Totals Coverage Status
Change from base Build 226: -0.1%
Covered Lines: 416
Relevant Lines: 450

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants