Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted client public interface. #5

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Deleted client public interface. #5

merged 1 commit into from
Nov 28, 2018

Conversation

triadev
Copy link
Owner

@triadev triadev commented Nov 28, 2018

No description provided.

@triadev triadev self-assigned this Nov 28, 2018
@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #5 into master will decrease coverage by 0.46%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #5      +/-   ##
============================================
- Coverage      48.6%   48.13%   -0.47%     
+ Complexity      149      144       -5     
============================================
  Files            21       21              
  Lines           500      482      -18     
============================================
- Hits            243      232      -11     
+ Misses          257      250       -7
Impacted Files Coverage Δ Complexity Δ
src/Console/Commands/Alias/Delete.php 62.5% <ø> (ø) 3 <0> (ø) ⬇️
src/Provider/ElasticsearchServiceProvider.php 90% <ø> (-0.91%) 3 <0> (ø)
src/ElasticsearchSearch.php 0% <0%> (ø) 19 <0> (-1) ⬇️
src/ElasticsearchMapping.php 0% <0%> (ø) 7 <1> (ø) ⬇️
src/Business/AbstractElasticsearch.php 100% <100%> (ø) 3 <2> (?)
src/ElasticsearchAlias.php 89.47% <100%> (-1.01%) 7 <0> (-1)
src/Console/Commands/Alias/Create.php 72.22% <68.75%> (+9.72%) 2 <0> (-1) ⬇️
src/ElasticsearchIndex.php 75.75% <83.33%> (-1.39%) 14 <0> (-1)
src/ElasticsearchDocument.php 79.72% <90%> (-0.54%) 25 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4037fe...6d76bb9. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 28, 2018

Pull Request Test Coverage Report for Build 67

  • 31 of 42 (73.81%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 45.393%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ElasticsearchDocument.php 9 10 90.0%
src/ElasticsearchIndex.php 5 6 83.33%
src/ElasticsearchMapping.php 0 2 0.0%
src/ElasticsearchSearch.php 0 2 0.0%
src/Console/Commands/Alias/Create.php 11 16 68.75%
Totals Coverage Status
Change from base Build 65: -0.6%
Covered Lines: 202
Relevant Lines: 445

💛 - Coveralls

@triadev triadev merged commit e3e9e92 into master Nov 28, 2018
@triadev triadev deleted the client_builder branch November 30, 2018 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants