Add KDE theming support #43
Open
+81
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-fedin
force-pushed
the
kde
branch
2 times, most recently
from
aebba29
to
afe600a
Compare
|
Do you know the name of the Qt module that provides |
|
@spikespaz I have a package (and a module) for nix in https://github.com/ilya-fedin/nur-repository. Regarding the Qt module, yeah, it's qtdeclarative. |
|
Tried it out, most KDE apps work fine for me, but Plasma system monitor doesn't follow the color scheme correctly and looks like this: KDE system settings app has the same problem. |
KDE applications are a notable part of the popular Qt software in the Linux world. Sadly, they have their own theming add-ons that are applied through QPlatformTheme. This adds support for all aspects of the KDE applications theming present in the plasma-integration QPlatformTheme: * KDE's QtQuick style bridging the currently set QtWidgets style (you may want to get QtQuick style choice in the settings UI in the future instead) * KDE's color schemes (the most important part as KDE applications don't fallback to QtQuick style/QtWidgets style/QPalette for colors) * KDE's icon engine applying KDE's color schemes to icons (to not to have black icons on black background)
|
Should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDE applications are a notable part of the popular Qt software in the Linux world.
Sadly, they have their own theming add-ons that are applied through QPlatformTheme.
This adds support for all aspects of the KDE applications theming present in the plasma-integration QPlatformTheme:
I haven't implemented preview for KDE color schemes as I don't really need it. I can try to make the preview part of the dialog to be hidden when a KDE color scheme is chosen or I can leave it as it is if you wish to implement it later.
I also have a qt5ct variant of this patch but I don't have a SourceForge account nor SVN experience to send it there... If you wish I can upload the patch here as a file.