BSP to BS2 conversion problems

[supadupaplex]

Hello, Triang3l. Your map converter is awesome but I have some problems with BSP to BS2 conversion. I don't know if you are aware of those issues, so I would just leave this list here:

1. Crashes on real PS2 (or red messages in PCSX2 "Program log" console). I found out that most of them are related to NPC movement. On start of first Half-life: Uplink map there are no crashes until Barney starts running to scientist or houndeye behind a door on the left is provoked.

2. Sometimes NPC's are unable to walk through their scripted path (Barney on anomalous materials entrance is not coming to open tram door, scientist can't walk through retractable bridge in the Blue Shift intro).

3. I don't know if it is normal, but BS2PC gives this error during conversion of Blue Shift map "ba_power2.bsp".
   

4. Texture fethching from some WAD's is broken. BS2PC just crashes during conversion if it tries to get textures from WAD.
   I performed a little investigation. Problem is in "bs2pc_wad.c" file. It starts when "mid" variable has zero value. It causes underflow of "high" variable and then "mid" and "low" are updated with enormous values that derived from "high".
   

It all ends with this exception.

Then I applied this quick hack, it allows to complete map conversion.

But there are still some checkerboarded textures in resulting map. Examples:

[supadupaplex]

Update. I found solution to some of mentioned problems.

1. Crashes were not related to *.bs2's. They were caused by PC *.nod files.

2. NPC's still stuck during scripted sequences. Maybe this is related to *.nod files too.

3. I changed these lines in bs2pc_subdiv.c:

#define BS2PC_MAX_POLY_VERTS 1024
#define BS2PC_MAX_POLY_STRIPS 512

to these:

#define BS2PC_MAX_POLY_VERTS 2048
#define BS2PC_MAX_POLY_STRIPS 1024

This change allowed to complete ba_power2 map conversion.

3. Checkerboarding problem was resolved with safer *.wad lump iteration in bs2pc_wad.c. I changed these lines:

while (low <= high) {
  mid = low + ((high - low) >> 1);
  difference = BS2PC_CompareTextureNames(lumps[mid].name, name);
  if (difference == 0) {
    lumpInfo = &lumps[mid];
    break;
  }
  if (difference > 0) {
    high = mid - 1;
  }
  else {
    low = mid + 1;
  }
}

to these:

for (int lmp = 0; lmp < wad->lumpCount; lmp++) {
  difference = BS2PC_CompareTextureNames(lumps[lmp].name, name);
  if (difference == 0) {
    lumpInfo = &lumps[lmp];
    break;
  }
}

Result:

[supadupaplex]

Update. I found solution to *.nod files problem. Issues with NPC's behavior were indeed caused by improper/missing *.nod files and a message "Node graph out of date, rebuilding ..." was a lie.