Heroes support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still need a lot of work in PlayerListener.java
It was hard but I did it. It not direct compatibility with Heroes but it also give protect for "strange" potions effect, like Heroes skills or (maybe) McMMO skills.
Closed
|
Sorry, I haven't had time to look at this. I'll merge and I'll fix the other issues that exist within the plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was hard but I did it. It not direct compatibility with Heroes but it also give protect for "strange" potions effect, like Heroes skills or (maybe) McMMO skills and other plugins.
Sorry for those unreal additions ad deletes, EGit don't like GitHub. I have added only "skills" to config.yml, SuppressWarnings annotations and change effect of DamageCause.Magic by using try-catch.
I hope that pull request will repair a lot of bugs with other plugins.