Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natural_dispersal: pathway level1 and level2 not correct #61

Closed
damianooldoni opened this issue Aug 29, 2019 · 7 comments
Closed

natural_dispersal: pathway level1 and level2 not correct #61

damianooldoni opened this issue Aug 29, 2019 · 7 comments
Assignees
Labels

Comments

@damianooldoni
Copy link
Contributor

damianooldoni commented Aug 29, 2019

I used the first underscore (_) to distinguish pathway level 1 and pathway level 2 (see pathway table). This is good for all possibilities except natural_dispersal, which is a pathway level1, and should be not divided in two levels.
Thanks to @SanderDevisscher to find this bug. I try to solve it now.

@damianooldoni
Copy link
Contributor Author

damianooldoni commented Aug 29, 2019

Bug solved: output file data_input_checklist_indicators.tsv is updated.
Internet site of pathways is not updated. Travis CI was taking too much time to make a new version and any attempt was aborted. Still, data are ok now.

@SanderDevisscher : check it again and close issue if problem is solved. Thanks.

@damianooldoni
Copy link
Contributor Author

@SanderDevisscher : can this be closed? I think so.

@SanderDevisscher
Copy link
Contributor

@damianooldoni Yes

@damianooldoni
Copy link
Contributor Author

damianooldoni commented Apr 9, 2020

Based on a scheme provided by @timadriaens, I find that natural_dispersal is a pathway level 2, the only one belonging to pathway level 1 unaided. I modify the mapping now.

Another little doubt: I see in unified taxa with pathway cbd_2014_pathway:unaided and other taxa with pathway cbd_2014_pathway:natural_dispersal. So, I will map cbd_2014_pathway:unaided by assigning value unknown to level 2:

pathway original (from description extension) pathway_level1 pathway_level2
cbd_2014_pathway:unaided unaided unknown
cbd_2014_pathway:natural_dispersal unaided natural_dispersal

@timadriaens , @SanderDevisscher , are you ok with this?

@timadriaens
Copy link
Member

This kind of question is of course easier to answer if I had a few species as an example. But indeed, unaided = spontaneous dispersal from other areas where the species was introduced. So it is the same as natural dispersal. In other words: yes, very much ok @damianooldoni, thx for spotting this (it is an important pathway for the Union List species).

@damianooldoni
Copy link
Contributor Author

damianooldoni commented Apr 14, 2020

Thanks @timadriaens. I wrote issues in each checklist where this occurred (see links above).

Actually there are two problems in one:

  • cbd_2014_pathway:natural_dispersal is wrong, it should be cbd_2014_pathway:unaided_natural_dispersal: see issue in RINSE pathway

  • cbd_2014_pathway:unaided is correct but based on your comment could be improved to cbd_2014_pathway:unaided_natural_dispersal (otherwise we have no info at level 2)

Meanwhile I write a patch in the preprocessing of unified data for checklist indicators and I map both cbd_2014_pathway:unaided and cbd_2014_pathway:natural_dispersal to cbd_2014_pathway:unaided_natural_dispersal.

@timadriaens
Copy link
Member

perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants