Updates example to use v2.0.2 instead of v1
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @stefanwb, Thanks for the PR. I'd rather keep it the way it is right now, as it shows an example using a released version. Even if I agree that master should always be production-ready, I'd prefer to keep it on the released version to make sure that people do not get their production down due to a mistake on the branch. Does this make sense to you? edit: Would it be possible for you to update the documentation with a |
Signed-off-by: Stefan Wessels Beljaars <swesselsbeljaars@schubergphilis.com>
stefanwb
changed the title
master instead of v1v2.0.2 instead of v1
|
Updated the PR as requested! Could you add the label |
triat
approved these changes
Oct 22, 2020
|
Thanks for the update. I've validated your PR for the hacktoberfest 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Wessels Beljaars swesselsbeljaars@schubergphilis.com