-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#31 Adds in the ability to select output fmt and file #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JamesWoolfenden,
Thanks for the PR, this is indeed a good idea to have the possibility to output the results in a file. I've left a couple of comments that we can discuss.
Co-authored-by: Tom Riat <tom@riat.dev>
Co-authored-by: Tom Riat <tom@riat.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last comment and this is good to go for the first version of it. I still have something that I need to see how it evolves over time.
Co-authored-by: Tom Riat <tom@riat.dev>
I'm after the results in a json file so I wrapped the existing cmdline params.