Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add major tag updater #50

Merged
merged 1 commit into from Feb 3, 2022
Merged

add major tag updater #50

merged 1 commit into from Feb 3, 2022

Conversation

figadore
Copy link
Contributor

@figadore figadore commented Feb 2, 2022

Fixes #49

I noticed the v3 tag in this repo, but it does not actually represent the latest minor/patch version within the major version as the tag would imply.

From the releasing-and-maintaining-actions docs:

We recommend creating releases using semantically versioned tags – for example, v1.1.3 – and keeping major (v1) and minor (v1.1) tags current to the latest appropriate commit.

Following this pattern allows consumers of the action to specify a major version, allowing automatic updates for any bug fixes or new features. I was using v3, but all of my builds broke when the go 1.17 update happened in the aquasecurity repo, even after v3.0.1 was released. For consumers who wish to tightly control the versions of actions, they are able to continue to pin their desired version down to the patch level. This is fairly standard practice among the most popular GitHub Actions, including https://github.com/actions/checkout

Additional details: as written here, this workflow will trigger automatically whenever a new release is created manually, since that is the method you mentioned is currently in use. Tested with regular manual releases, pre-releases, and draft releases that are then published

Copy link
Owner

@triat triat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks for the PR 👍

I'll make sure the initial one is created so you can start using the v3 tag from now.

@triat triat merged commit 888a4a0 into triat:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update floating tag
2 participants