Skip to content

Commit

Permalink
Fix query
Browse files Browse the repository at this point in the history
  • Loading branch information
otiai10 committed Aug 28, 2023
1 parent f5ae9bf commit b8464c2
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions server/slackbot/slashcommands.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ func (bot Bot) SlashCommands(w http.ResponseWriter, req *http.Request) {
req.ParseForm()
defer req.Body.Close()
text := req.Form.Get("text")
names := []string{}
names := []any{}
idx := mentionExp.SubexpIndex("name")
for _, m := range mentionExp.FindAllStringSubmatch(text, -1) {
fmt.Println(m[idx])
names = append(names, m[idx])
}
if len(names) == 0 {
Expand All @@ -52,7 +51,10 @@ func (bot Bot) SlashCommands(w http.ResponseWriter, req *http.Request) {
defer client.Close()

users := []models.Member{}
query := datastore.NewQuery(models.KindMember).FilterField("Slack.Name", "in", strings.Join(names, ","))
query := datastore.NewQuery(models.KindMember).FilterField("Slack.Name", "in", names)
// for _, name := range names {
// query = query.FilterField("Slack.Name", "=", name)
// }
if _, err := client.GetAll(ctx, query, &users); err != nil {
b, err := json.Marshal(map[string]string{
"text": fmt.Sprintf("データストアからのデータ取得に失敗しました。 @ten までご連絡ください。\n```%s```", err.Error()),
Expand All @@ -66,10 +68,12 @@ func (bot Bot) SlashCommands(w http.ResponseWriter, req *http.Request) {
return
}

fmt.Println(1001)
for _, u := range users {
fmt.Printf("%+v\n", u)
}

fmt.Println(1002)
fmt.Println(names)

Check failure

Code scanning / CodeQL

Log entries created from user input High

This log entry depends on a
user-provided value
.
w.WriteHeader(http.StatusOK)
}

0 comments on commit b8464c2

Please sign in to comment.