Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk_redis: Support connecting via unix socket #188

Closed
wants to merge 1 commit into from

Conversation

moschlar
Copy link
Contributor

No description provided.

@jonaskluger
Copy link
Contributor

Hey Moritz,
thanks for your pull request.
we removed the Python 2 support from our code base.
https://checkmk.com/check_mk-werks.php?werk_id=11080

Could you please rebase your code to the latest state of the master branch?
This should fix the failing python2 test.

Thanks a lot!
Best
Jonas

@jherbel
Copy link
Contributor

jherbel commented Jun 2, 2020

Hello Moritz,

thank you for this pull request. We will have a closer look at your patch and discuss internally on how and if we can implement it into the official code base.

Internal Ref: CMK-4600

@moschlar
Copy link
Contributor Author

moschlar commented Jun 2, 2020

Thanks @jherbel - that would be great.
(Just to explain: My use case is a GitLab Omnibus installation that configures most services to just use unix sockets by default)

@mo-ki
Copy link
Contributor

mo-ki commented Dec 22, 2021

It appears that sockets are now supported in the plugin.
I'm sorry that we didn't manage to consider your contribution earlier.
It is much appreciated nevertheless!

@mo-ki mo-ki closed this Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants