Fix Bug when ora_pmon Process of Oracle DB is not running #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modification fix the following Bug: - We have only one Oracle DB on the Host - The DB is already monitored ($MK_VARDIR/mk_oracle.found and Services discovered in checkmk) - When the ora_pmon process of the Oracle DB is not running the Plugin script must print all sections so that the check script on the server can handle this. But due to the bug in the If-Statement the condition is evaluated as true in function do_dummy_sections and is not printing the sections. As a result the Oracle Instance service goes Stale and we can't react on this. The if condition should check if the Variable MK_ORA_SECTIONS is set and not break the function. With this modification the ORA <Instance> service will go to UNKNOWN and we can get a notification.
|
Hi, thank you for this PR, just merged it. |
LarsMichelsen
pushed a commit
that referenced
this pull request
Oct 19, 2021
…rocess on target host The Oracle agent plugin now handles cases where the Oracle monitoring background process (<tt>ora_pmon</tt> on Unix systems) is not running correctly. In such cases, the agent plugin now prints out empty sections, s.t. the corresponding services on the Checkmk server go UNKNOWN. Closes #407 Change-Id: I4af77ec3e7e06c0a3195ef684704b54ca5098664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification fix the following Bug:
The if condition should check if the Variable MK_ORA_SECTIONS is set and not break the function. With this modification the ORA service will go to UNKNOWN and we can get a notification.