Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gatekeeper.yml gatekeeper Label check failed: required 1 of 'PR: safe to check', but found 0. #7995

Closed
drew2a opened this issue Apr 22, 2024 · 1 comment
Closed

Gatekeeper.yml gatekeeper Label check failed: required 1 of 'PR: safe to check', but found 0. #7995

drew2a opened this issue Apr 22, 2024 · 1 comment
Assignees
@drew2a
Labels
type: bug

Comments

@drew2a
Copy link
Collaborator

drew2a commented Apr 22, 2024

https://github.com/Tribler/tribler/actions/runs/8782094147?pr=7983

This error is harmless, and the fix will merely cosmetically hide it, as this check is part of the gatekeeping process.
@drew2a drew2a self-assigned this Apr 22, 2024
@drew2a drew2a added this to the 7.15.0 milestone Apr 22, 2024
@drew2a drew2a mentioned this issue Apr 22, 2024
Closed
@drew2a
Copy link
Collaborator Author

drew2a commented Apr 22, 2024

It turns out that with the current version of agilepathway/pull-request-label-checker:v1.6.29, it is not possible to hide this error:

https://github.com/agilepathway/label-checker/blob/f546ee28c49057f0b0232c70168e1afc9e86eaeb/internal/github/action.go#L63-L73

@drew2a drew2a closed this as completed Apr 22, 2024
@drew2a drew2a removed this from the 7.15.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drew2a drew2a

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove allowance for failure in PR checks Tribler/tribler
1 participant
@drew2a