Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vertical alignment grid lines to RF plot optionally #12

Merged

Conversation

medlin01GA
Copy link
Contributor

See feature suggestion to optionally aid readability on RF plots with many traces.

@medlin01GA
Copy link
Contributor Author

Sorry, I didn't realize the PR would create a new issue. Linking this to issue #11 and closing that duplicate ticket.

@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #12 into master will decrease coverage by 0.07%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   90.41%   90.33%   -0.08%     
==========================================
  Files          17       17              
  Lines        1941     1946       +5     
==========================================
+ Hits         1755     1758       +3     
- Misses        186      188       +2
Impacted Files Coverage Δ
rf/imaging.py 94.63% <60%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb00c7...ffe2f46. Read the comment docs.

@medlin01GA
Copy link
Contributor Author

Visual sample of proposed feature:
sample_rf_aligners

@trichter
Copy link
Owner

Thanks a lot for this useful addition. I will merge it.

@trichter trichter merged commit 06d02b1 into trichter:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants