update mtspec -> multitaper #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! I was not aware that the multitaper package could simply be used as a replacement for the outdated mtspec. I will first integrate this PR and after that look at the other PR.
This part of the code is only run if mtspec is successfully installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to keep throwing PRs at you, but I just realized that mtspec is no longer maintained and doesn't work past 3.8. I switched everything for the multitaper deconvolution over to the replacement, multitaper, which is essentially a python implementation of the fortran codes that used to be wrapped in mtspec. It works for 3.8+ (and for me that python upgrade also resolves an issue with toeplitz and numpy versions).