-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 tls support #298
Merged
Merged
1.0 tls support #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PS is about 92.7% completed at this point, but I forgot to mark the 'Draft' flag on it. i will request reviews when it is fully ready. |
PR ready for review. |
LimitlessEarth
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #296, which provides basic TLS support into
master
thanks to @u5surf. This PR extends that functionality intonext
, and provides additional functionality. In this port+extension, multiple TLS configs can be provided, and each origin configuration can be mapped to any one of the configured TLS sections. Further, each origin can support http only, http+https, or https only, depending upon the operator's preference. Trickster will only listen on the TLS and/or HTTP ports if origins are configured for either, and origins will only be routed to the TLS and/or HTTP router based on the operating configuration. Test coverage is also included, as well as a few ancillary bug fixes that were identified along the way during testing.