Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0 tls support #298

Merged
merged 50 commits into from
Oct 16, 2019
Merged

1.0 tls support #298

merged 50 commits into from
Oct 16, 2019

Conversation

jranson
Copy link
Member

@jranson jranson commented Oct 12, 2019

This builds on #296, which provides basic TLS support into master thanks to @u5surf. This PR extends that functionality into next, and provides additional functionality. In this port+extension, multiple TLS configs can be provided, and each origin configuration can be mapped to any one of the configured TLS sections. Further, each origin can support http only, http+https, or https only, depending upon the operator's preference. Trickster will only listen on the TLS and/or HTTP ports if origins are configured for either, and origins will only be routed to the TLS and/or HTTP router based on the operating configuration. Test coverage is also included, as well as a few ancillary bug fixes that were identified along the way during testing.

@jranson
Copy link
Member Author

jranson commented Oct 12, 2019

this PS is about 92.7% completed at this point, but I forgot to mark the 'Draft' flag on it. i will request reviews when it is fully ready.

@jranson
Copy link
Member Author

jranson commented Oct 14, 2019

PR ready for review.

@jranson jranson requested a review from a team October 14, 2019 18:52
Copy link
Contributor

@LimitlessEarth LimitlessEarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things.

.gitignore Show resolved Hide resolved
cmd/trickster/main.go Show resolved Hide resolved
@jranson jranson merged commit 825c87b into trickstercache:next Oct 16, 2019
@jranson jranson deleted the 1.0-tls-support branch October 21, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants