Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeQL Security Scanning #576

Merged
merged 1 commit into from Jun 10, 2021
Merged

Add CodeQL Security Scanning #576

merged 1 commit into from Jun 10, 2021

Conversation

caniszczyk
Copy link
Contributor

@caniszczyk
Add CodeQL Security Scanning
3316c28 
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 925518546

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 94.634%
Files with Coverage Reduction New Missed Lines %
pkg/cache/filesystem/filesystem.go 3 97.93%
Totals Coverage Status
Change from base Build 880051811: 0.006%
Covered Lines: 15977
Relevant Lines: 16883
💛 - Coveralls

jranson
jranson approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@jranson jranson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!! Don't worry about the coverage decrease - it's due to randomized timer durations intentionally creating race conditions in the test.

@jranson jranson merged commit 1ed16ff into main Jun 10, 2021
@caniszczyk caniszczyk deleted the add-codeql branch June 10, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jranson jranson jranson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caniszczyk @coveralls @jranson