Skip to content

Commit

Permalink
Close #1773: remove fixamo
Browse files Browse the repository at this point in the history
The Firefox Security team believe fixamo violates the AMO policy as it reduces
the security of Firefox.

I respectfully disagree, but I don't think it is a hill worth dying on.
  • Loading branch information
bovine3dom committed Aug 2, 2019
1 parent 10ab7b9 commit fef58f5
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .tridactylrc
Expand Up @@ -78,6 +78,10 @@ set hintnames numeric
" Defaults to 300ms but I'm a 'move fast and close the wrong tabs' kinda chap
set hintdelay 100

" Add helper commands that Mozillians think make Firefox irredeemably insecure
command fixamo_quiet jsb tri.excmds.setpref("privacy.resistFingerprinting.block_mozAddonManager", "true").then(tri.excmds.setpref("extensions.webextensions.restrictedDomains", '""'))
command fixamo js tri.excmds.setpref("privacy.resistFingerprinting.block_mozAddonManager", "true").then(tri.excmds.setpref("extensions.webextensions.restrictedDomains", '""').then(tri.excmds.fillcmdline_tmp(3000, "Permissions added to user.js. Please restart Firefox to make them take affect.")))

" Make Tridactyl work on more sites at the expense of some security
set csp clobber
fixamo_quiet
Expand Down
12 changes: 7 additions & 5 deletions src/excmds.ts
Expand Up @@ -500,28 +500,30 @@ export function setpref(key: string, ...value: string[]) {

/**
* Like [[fixamo]] but quieter.
*
* Now purely a placebo as [[fixamo]] has been removed.
*/
//#background
export async function fixamo_quiet() {
await setpref("privacy.resistFingerprinting.block_mozAddonManager", "true")
return setpref("extensions.webextensions.restrictedDomains", '""')
return logger.warning("fixamo_quiet has been removed at the behest of the Firefox Security team. See :help fixamo for more info.")
}

/**
*
* Simply sets
* Used to simply set
* ```js
* "privacy.resistFingerprinting.block_mozAddonManager":true
* "extensions.webextensions.restrictedDomains":""
* ```
* in about:config via user.js so that Tridactyl (and other extensions!) can be used on addons.mozilla.org and other sites.
*
* Removed at the request of the Firefox Security team. Replacements exist in our exemplar RC file.
*
* Requires `native` and a `restart`.
*/
//#background
export async function fixamo() {
await fixamo_quiet()
fillcmdline_tmp(3000, "Permissions added to user.js. Please restart Firefox to make them take affect.")
fillcmdline_tmp(10000, "fixamo has been removed at the request of the Firefox Security team. Alternatives exist in our exemplar RC file.")
}

/**
Expand Down

0 comments on commit fef58f5

Please sign in to comment.