Merge pull request #135 from brittonsmith/fl8

fix flake8 tests
trident-project · Jun 9, 2020 · 25e6dee · 25e6dee
2 parents eaaae0c + 5929a30
commit 25e6dee
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 21 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -109,6 +109,16 @@ commands:
                popd
             fi
 
+  lint:
+    description: "Lint."
+    steps:
+      - run:
+          name: "Lint."
+          command: |
+            source $BASH_ENV
+            source $HOME/venv/bin/activate
+            flake8 trident
+
   run-tests:
     description: "Build trident and run tests."
     parameters:
@@ -185,6 +195,7 @@ jobs:
 
       - install-dependencies:
           yttag: << parameters.yttag >>
+
       - configure-trident
 
       - save_cache:
@@ -195,6 +206,8 @@ jobs:
             - ~/venv
             - ~/yt-git
 
+      - lint
+
       - restore_cache:
           name: "Restore test data cache."
           key: test-data-v1

diff --git a/tests/test_flake8.py b/tests/test_flake8.py
diff --git a/trident/roman.py b/trident/roman.py
@@ -100,7 +100,7 @@ def from_roman(s):
     if not s:
         raise InvalidRomanNumeralError('Input can not be blank')
     if not romanNumeralPattern.search(s):
-        raise InvalidRomanNumeralError('Invalid Roman numeral: {s}'.format(s))
+        raise InvalidRomanNumeralError('Invalid Roman numeral: {0}'.format(s))
 
     result = 0
     index = 0