Merge pull request #194 from chummels/pbar

Fixing off-by-one on progress bar
trident-project · Mar 30, 2023 · 3944223 · 3944223
2 parents ae833d4 + 1a3e63a
commit 3944223
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/trident/absorption_spectrum/absorption_spectrum.py b/trident/absorption_spectrum/absorption_spectrum.py
@@ -677,7 +677,7 @@ def _add_continua_to_spectrum(self, field_data, use_peculiar_velocity,
                               continuum['index']) * \
                     (column_density[lixel] / continuum['normalization'])
                 self.tau_field[left_index[lixel]:right_index[lixel]] += cont_tau.d
-                pbar.update(i)
+                pbar.update()
             pbar.finish()
 
     def _add_lines_to_spectrum(self, field_data, use_peculiar_velocity,
@@ -814,7 +814,7 @@ def _add_lines_to_spectrum(self, field_data, use_peculiar_velocity,
                 # if there is a ray element with temperature = 0 or column
                 # density = 0, skip it
                 if (thermal_b[i] == 0.) or (cdens[i] == 0.):
-                    pbar.update(i)
+                    pbar.update()
                     continue
 
                 # the virtual window into which the line is deposited initially
@@ -915,7 +915,7 @@ def _add_lines_to_spectrum(self, field_data, use_peculiar_velocity,
                     window_width_in_bins *= 2
 
                 if center_index is None:
-                    pbar.update(i)
+                    pbar.update()
                     continue
 
                 # Numerically integrate the virtual bins to calculate a
@@ -941,7 +941,7 @@ def _add_lines_to_spectrum(self, field_data, use_peculiar_velocity,
                 # all then skip the deposition
                 if ((left_index >= self.lambda_field.size) or \
                     (right_index < 0)):
-                    pbar.update(i)
+                    pbar.update()
                     continue
 
                 # otherwise, determine how much of the original spectrum
@@ -975,7 +975,7 @@ def _add_lines_to_spectrum(self, field_data, use_peculiar_velocity,
                                                 'redshift': redshift[i],
                                                 'redshift_eff': redshift_eff[i],
                                                 'v_pec': peculiar_velocity})
-                pbar.update(i)
+                pbar.update()
             pbar.finish()
 
             # Expand the tau_field array to match the updated wavelength