Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] allow access to find_outputs kwarg from make_compound_ray #117

Merged
merged 6 commits into from
Feb 7, 2020

Conversation

brittonsmith
Copy link
Collaborator

This fixes the problem associated with Issue #116. make_compound_ray attempts to load the last dataset on the dataset list to do field checking. However, if that dataset isn't present, we get an error. In the instance where not all data is present, the user would want to be able to pass the find_outputs keyword to the LightRay generator to only use outputs that are present. This PR allows one to do that.

I've also bumped the cache versions as a hail mary that it will fix the failing tests.

@brittonsmith
Copy link
Collaborator Author

@chummels, along with PR #49 to yt_astro_analysis, this seems to solve the issues that stemmed from the discussion in Issue #116. You ok with merging this?

Copy link
Collaborator

@chummels chummels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting a minor tweak to the kwarg placement, but other than that, this looks good to me! Thanks for addressing this bug. Once that is changed, feel free to merge.

trident/ray_generator.py Outdated Show resolved Hide resolved
trident/ray_generator.py Outdated Show resolved Hide resolved
@chummels chummels merged commit f87549e into trident-project:master Feb 7, 2020
@brittonsmith brittonsmith deleted the outputs branch February 8, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants