Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare legacy branch for parking #129

Merged
merged 5 commits into from Apr 23, 2020

Conversation

brittonsmith
Copy link
Collaborator

The recent yt-3.6 release was the last of the 3.x series, so there is no longer any point for the legacy branch to continue to test with the yt master branch. Soon, that will be exclusively for yt-4.0 development and will not work with Trident's legacy branch. This PR decouples Trident legacy branch testing from yt master and instead tests exclusively on the yt-3.6.0 release. I've also made the following changes/updates:

  1. update to most recent Python versions for testing
  2. remove Python 2 __future__ module imports
  3. move intermediate Python versions to weekly testing and only test PRs with oldest and newest versions
  4. update caches since I changed the gold standard to yt-3.6.0
  5. remove testing entries for Trident master branch. It was unnecessary of me to include those in this branch.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 75.407%

Files with Coverage Reduction New Missed Lines %
/home/circleci/trident/trident/absorption_spectrum/absorption_spectrum.py 34 92.37%
Totals Coverage Status
Change from base Build 498: -0.01%
Covered Lines: 1852
Relevant Lines: 2456

💛 - Coveralls

@brittonsmith brittonsmith merged commit 575717c into trident-project:legacy Apr 23, 2020
@chummels
Copy link
Collaborator

Thanks for doing this! Looking forward to just having master soon!

@brittonsmith brittonsmith deleted the legup branch April 24, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants