New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing gold standard script to work with circle ci #133
Conversation
Actually, no, this doesn't address everything. This merely fixes the breakage of the script in accessing the travis yml file. But all of the other text in the script that helped you actually build the gold standard was removed, presumably during the switch to circle ci. I'm not sure why. Was there something wrong with the build order that was given to the user described in the docs: https://trident.readthedocs.io/en/latest/testing.html#generating-gold-standard-answer-test-results-for-comparison ? It's useful to be explicit with the user in regenerating thegold standards, and I personally find it helpful when I haven't built the gold standards in a long time to remember the steps. |
I'm not sure what other text you're referring to. Between this script and the docs you link to, I don't see anything else that one needs to know to run testing. The build script is written to most efficiently use the testing workflow set up by the service, nothing more. It's not meant to be used as documentation. I missed this because it's not tested functionality. I left a comment on how it could be. |
@brittonsmith You're right. I had mistakenly thought that the text that was in the docs about how to generate the gold standards was also meant to be printed to STDOUT as part of this script. But I looked back at past versions and that was never the case. Sorry about that. |
I have now updated the script to include a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. This looks great. Definitely an unlikely just in case test, but I'm happy it's there. I'll merge this. Thanks for doing it.
This should fix issue #132 so the gold standard script now work with circle_ci instead of travis.