New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing voigt_old functionality #139
Conversation
Pull Request Test Coverage Report for Build 1093
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you still want to investigate why the test was able to pass all this time? If not, I'm fine for this to be merged.
@@ -46,7 +46,7 @@ | |||
def test_voigt_profiles(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this test was meant to compare the two functions. We probably don't need to keep it.
|
||
def voigt_old(a, u): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RIP voigt_old
. You were a good function.
Trident has historically had two separate methods for numerically integrating the voigt profiles: one from some old IDL routines using chebyshev polonomials and one using a SciPy method. If you have scipy installed it would use the scipy method, otherwise it would use the IDL routine. At some point, the IDL routine stopped working. This PR removes that functionality and makes SciPy a hard dependency of Trident.
Note: We have a test to ensure that the two methods get the same values for a set of inputs in
test_absorption_spectrum.py
, which never seemed to fail. I want to investigate this first before merging to find out what went awry here.