Setting new gold standards to resolve failing CI tests #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix the circleci tests by bumping the cache keynames and clearing the cache.
OK, so that didn't work. But digging in further, I think I see what the problem is.
It appears that the failing tests occur when we try to generate the answer tests with the gold standards before even testing the tip of trident/yt. The gold standard for yt and trident are from over a year ago with version in between yt4 and yt4.0.1. I can run them locally no problem and generate the answer tests. However, a change was made to
yt_astro_analysis
setting a hard dependency for yt4.0.1, which has changes incompatible with the trident gold standard. So when circleCI tries to generate the answer tests, it tries to install the gold standards, butyt_astro_analysis
bumps the version of yt up to a newer version that causes everything to fail. So the solution is just to bump the gold standard versions of the code to current. I'm just arbitrarily choosing yt4.0.0's release (yt4.0.1 was not in the yt commit tree?!) and the current trident tip as the gold standards since I've personally confirmed locally that these are consistent with the previous gold standard. This should finally resolve these stupid circleCI testing failures.