Logging info doesn't use correct units #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a small bug from the addition of velocities. In the logging info it tries to compare
thermal_width
(which is in angstroms) toself.bin_width
(which can be in km/s). YT then complains and the program crashes. This only occurs of course if you set the resolution relatively high.Changing to
my_width
(like in the if statement above) fixes things nicely so that the units always match.I tried to search through and didn't find any other case where
thermal_width
was still being used incorrectly.