Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging info doesn't use correct units #99

Merged
merged 1 commit into from Sep 25, 2019

Conversation

biboyd
Copy link
Contributor

@biboyd biboyd commented Sep 25, 2019

This looks like a small bug from the addition of velocities. In the logging info it tries to compare thermal_width (which is in angstroms) to self.bin_width (which can be in km/s). YT then complains and the program crashes. This only occurs of course if you set the resolution relatively high.

Changing to my_width (like in the if statement above) fixes things nicely so that the units always match.

I tried to search through and didn't find any other case where thermal_width was still being used incorrectly.

@brittonsmith
Copy link
Collaborator

@boydbre1, good catch! Thanks for fixing this.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 991

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 74.723%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/trident-project/trident/trident/ion_balance.py 24 84.06%
Totals Coverage Status
Change from base Build 988: -0.06%
Covered Lines: 1756
Relevant Lines: 2350

💛 - Coveralls

@brittonsmith brittonsmith merged commit ac41126 into trident-project:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants