Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test sudoers cmnd_list #144

Merged
merged 1 commit into from
Mar 27, 2023
Merged

test sudoers cmnd_list #144

merged 1 commit into from
Mar 27, 2023

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Mar 24, 2023

cc #96

@japaric japaric mentioned this pull request Mar 24, 2023
Open
56 tasks
@japaric japaric marked this pull request as ready for review March 24, 2023 16:19
squell
squell approved these changes Mar 27, 2023
View reviewed changes
test-framework/sudo-compliance-tests/src/sudoers/cmnd.rs

// it applies not only to the command is next to but to all commands that follow
#[test]
fn nopasswd_is_sticky() -> Result<()> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: all tags are sticky. I would also like to see a test that has PASSWD in it but I can add that myself later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I.e. something like NOPASSWD: /bin/ls, PASSWD: /bin/ls)

test-framework/sudo-compliance-tests/src/sudoers/cmnd.rs
#[test]
#[ignore]
fn runas_override() -> Result<()> {
let env = Env(format!("ALL ALL = (root) /bin/ls, ({USERNAME}) /bin/true"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@squell squell added this pull request to the merge queue Mar 27, 2023
Merged via the queue into main with commit 7c5a0cd Mar 27, 2023
@japaric japaric deleted the test-sudoers-cmnd branch March 27, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squell squell squell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@japaric @squell